Repository navigation
fix(gh-aw): keep compiled expressions valid - #2037
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 5 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | All 1 Copilot thread(s) resolved |
| ✅ | CI passing | All checks passing |
Files Changed (10 files, +188 −15)
| File | +/− |
|---|---|
.changeset/gh-aw-compiled-expression.md |
+8 −0 |
.github/agents.md |
+12 −0 |
.squad-templates/skills/gh-aw-enlistment/SKILL.md |
+10 −0 |
docs/src/content/docs/guide/gh-aw.md |
+45 −14 |
packages/squad-cli/templates/skills/gh-aw-enlistment/SKILL.md |
+10 −0 |
packages/squad-sdk/templates/skills/gh-aw-enlistment/SKILL.md |
+10 −0 |
templates/skills/gh-aw-enlistment/SKILL.md |
+10 −0 |
test/gh-aw-enlistment-skill.test.ts |
+36 −0 |
test/gh-aw-quality.test.ts |
+46 −0 |
workflows/squad.md |
+1 −1 |
Total: +188 −15
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
🟠 Impact Analysis — PR #2037Risk tier: 🟠 HIGH 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
docs (1 file)
root (3 files)
squad-cli (1 file)
squad-sdk (1 file)
templates (1 file)
tests (2 files)
This report is generated automatically for every PR. See #733 for details. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate findings remain for scan error handling and the required changelog or changeset.
Get a fresh assessment by requesting another Copilot review.
Review tier: Lite
Findings: 1
Open findings (1)
What changed in this PR
Updates gh-aw activation expressions to remain valid after JSON serialization and adds regression coverage and setup guidance.
Changes:
- Replaces the unsafe
&&expression form. - Adds compiled-artifact and mutation regression tests.
- Documents emitted-lock validation in guides and skill mirrors.
| File | Summary |
|---|---|
workflows/squad.md |
Updates the activation expression. |
test/gh-aw-quality.test.ts |
Adds serialization regression coverage. |
templates/skills/gh-aw-enlistment/SKILL.md |
Documents lockfile scanning. |
packages/squad-sdk/templates/skills/gh-aw-enlistment/SKILL.md |
Mirrors skill guidance. |
packages/squad-cli/templates/skills/gh-aw-enlistment/SKILL.md |
Mirrors skill guidance. |
docs/src/content/docs/guide/gh-aw.md |
Documents emitted-lock validation. |
.squad-templates/skills/gh-aw-enlistment/SKILL.md |
Updates canonical skill guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 14, 2026
jplummer01
pushed a commit
to jplummer01/squad
that referenced
this pull request
Sep 17, 2026
Part of github#2037 and github#2038 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activation-commentsboolean with an equivalent form that survives gh-aw JSON serialization&&form emits invalid\\u0026\\u0026inside a GitHub expressionRoot cause
gh aw compile --strictaccepted the source, but gh-aw v0.89.2 serialized&&as literal\\u0026\\u0026inside${{ ... }}inGH_AW_SAFE_OUTPUT_MESSAGES. GitHub rejected the resultingsquad.lock.ymlbefore creating any jobs, so the run had no logs.Validation
npm run build: passed